-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): create-nx-workspace should work with custom presets on windows #16473
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/enoent-when-generating-custom-preset-on-windows
Apr 21, 2023
Merged
fix(misc): create-nx-workspace should work with custom presets on windows #16473
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/enoent-when-generating-custom-preset-on-windows
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
FrozenPandaz,
vsavkin,
jaysoo and
JamesHenry
as code owners
April 21, 2023 20:02
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
force-pushed
the
fix/enoent-when-generating-custom-preset-on-windows
branch
from
April 21, 2023 20:15
dece7d3
to
6400b70
Compare
FrozenPandaz
approved these changes
Apr 21, 2023
great job @AgentEnder ! thank you for this! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
AgentEnder
deleted the
fix/enoent-when-generating-custom-preset-on-windows
branch
April 28, 2023 14:42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
create-nx-workspace
fails when trying to run something like this on windows:This is because
npx
is actuallynpx.cmd
on windows - but, usingshell: true
also fixes it and handles similar problems for yarn or pnpx.Expected Behavior
create-nx-workspace
can generate custom presets on windowsRelated Issue(s)
Fixes #16231